Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Params: Align to upstream. #452

Merged
merged 4 commits into from
Apr 13, 2023
Merged

Params: Align to upstream. #452

merged 4 commits into from
Apr 13, 2023

Conversation

Gacko
Copy link
Member

@Gacko Gacko commented Apr 13, 2023

Tests on workload clusters (not always required)

For changes in the chart, chart templates, and ingress controller container images, I executed the following tests
to verify them working in live enviromnents:

Test / Provider AWS Azure KVM
Upgrade from previous version
Existing Ingress resources are reconciled correctly
Fresh install
Fresh Ingress resources are reconciled correctly

Testing was done using hello-world-app.

Hint for KVM:

kubectl port-forward -n kube-system svc/nginx-ingress-controller-app 8080:80
ingress_domain=host.configured.in.ingress; curl --connect-to "$ingress_domain:80:127.0.0.1:8080" "http://$ingress_domain" -v

@Gacko
Copy link
Member Author

Gacko commented Apr 13, 2023

I'm only removing those values which align to the default values documented here. So I guess the only one still required, mostly for security reasons, is controller.disableExternalNameForwarding (--disable-svc-external-name).

@Gacko Gacko marked this pull request as ready for review April 13, 2023 10:27
@Gacko Gacko requested a review from a team as a code owner April 13, 2023 10:27
@Gacko Gacko merged commit 2885c15 into main Apr 13, 2023
@Gacko Gacko deleted the feature/remove-custom-values branch April 13, 2023 12:38
Gacko added a commit that referenced this pull request Oct 18, 2023
* Params: Remove `controller.annotationsPrefix`.

* Params: Remove `controller.defaultSSLCertificate`.

* Params: Remove `controller.enableSSLChainCompletion`.

* Params: Remove `controller.updateIngressStatus`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant