Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployment/DaemonSet: Remove duplicate Prometheus annotations. #455

Merged
merged 1 commit into from
Apr 17, 2023

Conversation

Gacko
Copy link
Member

@Gacko Gacko commented Apr 17, 2023

Tests on workload clusters (not always required)

For changes in the chart, chart templates, and ingress controller container images, I executed the following tests
to verify them working in live enviromnents:

Test / Provider AWS Azure KVM
Upgrade from previous version
Existing Ingress resources are reconciled correctly
Fresh install
Fresh Ingress resources are reconciled correctly

Testing was done using hello-world-app.

Hint for KVM:

kubectl port-forward -n kube-system svc/nginx-ingress-controller-app 8080:80
ingress_domain=host.configured.in.ingress; curl --connect-to "$ingress_domain:80:127.0.0.1:8080" "http://$ingress_domain" -v

@Gacko Gacko force-pushed the fix/prometheus-annotations branch 2 times, most recently from ff79c77 to 001f382 Compare April 17, 2023 11:35
@Gacko Gacko force-pushed the fix/prometheus-annotations branch from 001f382 to 336eb6f Compare April 17, 2023 11:37
@Gacko
Copy link
Member Author

Gacko commented Apr 17, 2023

Changed according to docs from our intranet and discussion in #team-atlas.

@Gacko Gacko marked this pull request as ready for review April 17, 2023 11:39
@Gacko Gacko requested a review from a team as a code owner April 17, 2023 11:39
@Gacko Gacko merged commit b1b15c6 into main Apr 17, 2023
@Gacko Gacko deleted the fix/prometheus-annotations branch April 17, 2023 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants