Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Values: Remove configmap keys matching defaults. #457

Merged
merged 5 commits into from
Apr 18, 2023

Conversation

Gacko
Copy link
Member

@Gacko Gacko commented Apr 17, 2023

This PR removes those keys from configmap which already match their default documented in here.

Tests on workload clusters (not always required)

For changes in the chart, chart templates, and ingress controller container images, I executed the following tests
to verify them working in live enviromnents:

Test / Provider AWS Azure KVM
Upgrade from previous version
Existing Ingress resources are reconciled correctly
Fresh install
Fresh Ingress resources are reconciled correctly

Testing was done using hello-world-app.

Hint for KVM:

kubectl port-forward -n kube-system svc/nginx-ingress-controller-app 8080:80
ingress_domain=host.configured.in.ingress; curl --connect-to "$ingress_domain:80:127.0.0.1:8080" "http://$ingress_domain" -v

@Gacko
Copy link
Member Author

Gacko commented Apr 17, 2023

At first I felt brave enough to also remove configmap.hsts, but the amount of issues in the past changed my mind. Not sure how to proceed on this... I'd like to move all the configmap.* stuff to controller.config in the future.

@Gacko Gacko marked this pull request as ready for review April 17, 2023 17:57
@Gacko Gacko requested a review from a team as a code owner April 17, 2023 17:57
@Gacko Gacko force-pushed the feature/remove-configmap-values branch from 3d19f6d to 83b2c48 Compare April 18, 2023 07:29
@Gacko Gacko changed the base branch from main to release-v2.29.x April 18, 2023 07:29
@Gacko Gacko merged commit c073eb2 into release-v2.29.x Apr 18, 2023
@Gacko Gacko deleted the feature/remove-configmap-values branch April 18, 2023 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant