Chart: Rename to ingress-nginx.
#464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since fixing CI would require to rename the whole repository, I'm going to pause here and start into weekend... probably better. 😌 |
Gacko
force-pushed
the
feature/rename-chart
branch
4 times, most recently
from
068fe29
to
a2c7e88
Compare
Gacko
force-pushed
the
feature/rename-chart
branch
25 times, most recently
from
d49d592
to
290e179
Compare
Gacko
force-pushed
the
feature/rename-chart
branch
3 times, most recently
from
8d935c0
to
45b2b50
Compare
|
Only thing left to do would be updating the test dependencies and updating the remaining occurrences of |
Gacko
force-pushed
the
feature/rename-chart
branch
from
0bf68bc
to
282ab89
Compare
|
I just renamed all occurrences. |
Gacko
force-pushed
the
feature/rename-chart
branch
3 times, most recently
from
525cda2
to
57ebdf8
Compare
|
Works as a fresh install in AWS & Azure, gonna explore & document a migration path for the "existing" part. |
Gacko
force-pushed
the
feature/rename-chart
branch
2 times, most recently
from
15d171c
to
4e98c94
Compare
Gacko
changed the title
ingress-nginx.ingress-nginx.
Gacko
changed the title
ingress-nginx.ingress-nginx.
Gacko
changed the title
ingress-nginx.nginx-ingress-controller-app to ingress-nginx.
Gacko
changed the title
nginx-ingress-controller-app to ingress-nginx.ingress-nginx.
Gacko
force-pushed
the
feature/rename-chart
branch
from
4e98c94
to
720ffa6
Compare
Gacko
force-pushed
the
feature/rename-chart
branch
from
720ffa6
to
564ad00
Compare
mleisa
approved these changes
May 8, 2023
|
lgtm! |
mcharriere
approved these changes
May 8, 2023
Gacko
added a commit
that referenced
this pull request
Oct 18, 2023
* Repository: Rename `nginx-ingress-controller-app` to `ingress-nginx`. * CircleCI: Do not push to app collections. * Tests: Fix & rework.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For changes in the chart, chart templates and container images, I executed the following tests, using the
hello-worldapp, to verify them in live environments:Ingressresources are reconciledIngressresources are reconciled