Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Service: Align features from external service to internal one. #467

Merged
merged 1 commit into from
Apr 27, 2023
Merged

Service: Align features from external service to internal one. #467

merged 1 commit into from
Apr 27, 2023

Conversation

Gacko
Copy link
Member

@Gacko Gacko commented Apr 26, 2023 •
edited
Loading

For changes in the chart, chart templates and container images, I executed the following tests, using the hello-world app, to verify them in live environments:

  • Upgrade from previous version
    • AWS
    • Azure
  • Existing Ingress resources are reconciled
    • AWS
    • Azure
  • Fresh install
    • AWS
    • Azure
  • Fresh Ingress resources are reconciled
    • AWS
    • Azure

@Gacko Gacko marked this pull request as ready for review April 26, 2023 16:05
@Gacko Gacko requested a review from a team as a code owner April 26, 2023 16:05
@Gacko Gacko enabled auto-merge (squash) April 26, 2023 16:20
ubergesundheit
ubergesundheit approved these changes Apr 27, 2023
View reviewed changes
Copy link
Member

@ubergesundheit ubergesundheit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gacko Gacko merged commit 99029a9 into main Apr 27, 2023
@Gacko Gacko deleted the pull/467 branch April 27, 2023 13:03
Gacko added a commit that referenced this pull request Oct 18, 2023
@Gacko
Service: Align features from external service to internal one. (#467)
18066c4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ubergesundheit ubergesundheit ubergesundheit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Gacko @ubergesundheit