Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PDB: Add controller.annotations. #481

Merged
merged 1 commit into from
May 11, 2023
Merged

PDB: Add controller.annotations. #481

merged 1 commit into from
May 11, 2023

Conversation

Gacko
Copy link
Member

@Gacko Gacko commented May 11, 2023

For changes in the chart, chart templates and container images, I executed the following tests, using the hello-world app, to verify them in live environments:

  • Upgrade from previous version
    • AWS
    • Azure
  • Existing Ingress resources are reconciled
    • AWS
    • Azure
  • Fresh install
    • AWS
    • Azure
  • Fresh Ingress resources are reconciled
    • AWS
    • Azure

@Gacko Gacko requested a review from a team as a code owner May 11, 2023 07:34
mcharriere
mcharriere approved these changes May 11, 2023
View reviewed changes
Copy link
Contributor

@mcharriere mcharriere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it feels weird that the pdb shares the annotations with the deployment, but upstream 🤷🏻‍♂️

@Gacko Gacko enabled auto-merge (squash) May 11, 2023 08:46
@Gacko Gacko merged commit 2c811b6 into main May 11, 2023
@Gacko Gacko deleted the pull/481 branch May 11, 2023 08:50
Gacko added a commit that referenced this pull request Oct 18, 2023
@Gacko
PDB: Add controller.annotations. (#481)
b0ac90b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcharriere mcharriere mcharriere approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Gacko @mcharriere