Metrics: Use ServiceMonitor.
#494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuentinBisson
requested changes
Jun 7, 2023
There was a problem hiding this comment.
This is awesome thank you :)
Do you mind adding our default metric drop in the values to avoid overloading prometheus https://github.com/giantswarm/prometheus-meta-operator/blob/adf0fe2e6ca50a200c78eaafbbae580569502b65/files/templates/scrapeconfigs/additional-scrape-configs.template.yaml#LL585C2-L588C17 ?
Hopefully this is only until we have mimir
|
@QuentinBisson: I added the metrics relabeling - does it look ok? |
QuentinBisson
approved these changes
Jun 7, 2023
|
Yes, doing so right now, but wanted to have a first look before :) |
|
Of course :) |
ubergesundheit
approved these changes
Jun 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For changes in the chart, chart templates and container images, I executed the following tests, using the
hello-worldapp, to verify them in live environments:Ingressresources are reconciledIngressresources are reconciled