Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service: Add controller.service.loadBalancerClass. #503

Merged
merged 1 commit into from
Jun 26, 2023
Merged

Service: Add controller.service.loadBalancerClass. #503

merged 1 commit into from
Jun 26, 2023

Conversation

Gacko
Copy link
Member

@Gacko Gacko commented Jun 26, 2023

For changes in the chart, chart templates and container images, I executed the following tests, using the hello-world app, to verify them in live environments:

  • Upgrade from previous version
    • AWS
    • Azure
  • Existing Ingress resources are reconciled
    • AWS
    • Azure
  • Fresh install
    • AWS
    • Azure
  • Fresh Ingress resources are reconciled
    • AWS
    • Azure

@Gacko Gacko requested a review from a team as a code owner June 26, 2023 11:16
Copy link
Member

@ubergesundheit ubergesundheit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gacko
Copy link
Member Author

Gacko commented Jun 26, 2023

As stated in the change log, this value can not be changed for existing services. So we can not test the upgrade.

@Gacko Gacko merged commit e41e632 into main Jun 26, 2023
3 checks passed
@Gacko Gacko deleted the pull/503 branch June 26, 2023 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants