Deployment: Ignore replicas with KEDA enabled.
#513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gacko
changed the title
replicaCount with KEDA enabled.replicas with KEDA enabled.
| @@ -20,7 +20,7 @@ spec: | |||
| matchLabels: | |||
| {{- include "ingress-nginx.selectorLabels" . | nindent 6 }} | |||
| app.kubernetes.io/component: controller | |||
| {{- if not .Values.controller.autoscaling.enabled }} | |||
| {{- if not (or .Values.controller.autoscaling.enabled .Values.controller.keda.enabled) }} | |||
There was a problem hiding this comment.
I see this is already present in the upstream fork main and upstream-main branch. Just out of curiosity? Couldn't this also be synced to here using vendir sync? Or do you want to keep changes atomic for now?
There was a problem hiding this comment.
I wanted to do a last manual sync before using vendir.
ubergesundheit
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For changes in the chart, chart templates and container images, I executed the following tests, using the
hello-worldapp, to verify them in live environments:Ingressresources are reconciledIngressresources are reconciled