Service: Fix wildcard subdomain. #539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gacko
changed the title
controller.service.subdomain or controller.service.internal.subdomain contains a wildcard domain
Gacko
force-pushed
the
wildcard-external-dns-hostname
branch
from
a536ba1
to
7c25858
Compare
Gacko
force-pushed
the
wildcard-external-dns-hostname
branch
from
7c25858
to
5a92c3b
Compare
Gacko
approved these changes
Oct 11, 2023
|
I'm currently working on another PR which I probably will propose tonight and merge tomorrow. Afterwards I'll forge a new minor release, so there's no need for you to do this on your own. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards https://github.com/giantswarm/giantswarm/issues/28355
The error was
Likely the YAML parser saw
external-dns.alpha.kubernetes.io/hostname: *.blaand instead wanted to see a YAML anchor name. Quote the label value as a simple fix.Found while testing on CAPA with live customer configuration taken from v2.x of the app.
For changes in the chart, chart templates and container images, I executed the following tests, using the
hello-worldapp, to verify them in live environments:none