Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chart: Tighten securityContexts and Pod Security Policies. #540

Merged
merged 1 commit into from
Oct 12, 2023
Merged

Chart: Tighten securityContexts and Pod Security Policies. #540

merged 1 commit into from
Oct 12, 2023

Conversation

Gacko
Copy link
Member

@Gacko Gacko commented Oct 11, 2023 •
edited
Loading

For changes in the chart, chart templates and container images, I executed the following tests, using the hello-world app, to verify them in live environments:

  • Upgrade from previous version
    • AWS
    • Azure
  • Existing Ingress resources are reconciled
    • AWS
    • Azure
  • Fresh install
    • AWS
    • Azure
  • Fresh Ingress resources are reconciled
    • AWS
    • Azure

@Gacko Gacko requested a review from a team as a code owner October 11, 2023 20:59
@Gacko Gacko force-pushed the pull/540 branch 2 times, most recently from 01997eb to 66f79c3 Compare October 11, 2023 21:06
@Gacko Gacko enabled auto-merge (squash) October 11, 2023 21:39
@Gacko Gacko disabled auto-merge October 12, 2023 07:56
mcharriere
mcharriere approved these changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@mcharriere mcharriere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with 2 minor optional comments that you can address if you want :)

@Gacko
Copy link
Member Author

Gacko commented Oct 12, 2023

Added comments. Thank you very much for your effort on reviewing! ❤️

@Gacko Gacko enabled auto-merge (squash) October 12, 2023 09:14
@Gacko Gacko merged commit 18f4bce into main Oct 12, 2023
6 checks passed
@Gacko Gacko deleted the pull/540 branch October 12, 2023 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcharriere mcharriere mcharriere approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Gacko @mcharriere