Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Values: Enable controller.config.strict-validate-path-type by default. #553

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

Gacko
Copy link
Member

@Gacko Gacko commented Oct 18, 2023

For changes in the chart, chart templates and container images, I executed the following tests, using the hello-world app, to verify them in live environments:

  • Upgrade from previous version
    • AWS
    • Azure
  • Existing Ingress resources are reconciled
    • AWS
    • Azure
  • Fresh install
    • AWS
    • Azure
  • Fresh Ingress resources are reconciled
    • AWS
    • Azure

@Gacko Gacko requested a review from a team as a code owner October 18, 2023 11:37
@Gacko
Copy link
Member Author

Gacko commented Oct 18, 2023

Going to update CHANGELOG.md once I figured how this is affecting existing Ingress resources or only those created or updated after deploying this change.

@Gacko
Copy link
Member Author

Gacko commented Oct 18, 2023

Also see kubernetes/ingress-nginx#10186. Upstream is about to enable this by default in one of their upcoming releases anyway.

@Gacko Gacko force-pushed the pull/553 branch 2 times, most recently from b5c04da to ab37650 Compare October 18, 2023 13:05
@Gacko Gacko merged commit 4ff2375 into main Oct 18, 2023
3 of 5 checks passed
@Gacko Gacko deleted the pull/553 branch October 18, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants