Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Service: Add CAPZ support. #587

Merged
merged 1 commit into from
Jan 15, 2024
Merged

Service: Add CAPZ support. #587

merged 1 commit into from
Jan 15, 2024

Conversation

ubergesundheit
Copy link
Member

I performed the following tests using the hello-world app to verify my changes in live environments:

  • Fresh installation
  • Fresh Ingress resources are reconciled
  • Upgrade from previous version
  • Existing Ingress resources are reconciled

@Gacko Gacko changed the title Add CAPZ support Service: Add CAPZ support. Jan 11, 2024
erkanerol
erkanerol approved these changes Jan 11, 2024
View reviewed changes
Copy link
Contributor

@erkanerol erkanerol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested for CAPZ. It is fine.

@ubergesundheit ubergesundheit marked this pull request as ready for review January 15, 2024 09:49
@ubergesundheit ubergesundheit requested a review from a team as a code owner January 15, 2024 09:49
@ubergesundheit ubergesundheit mentioned this pull request Jan 15, 2024
Closed
@kopiczko
Copy link
Member

Will it work ok with vendir?

@ubergesundheit
Copy link
Member Author

ubergesundheit commented Jan 15, 2024 •
edited
Loading

Will it work ok with vendir?

No, I wanted to talk to you about this on wednesday in office hours

@ubergesundheit ubergesundheit merged commit 3c1ad75 into main Jan 15, 2024
5 checks passed
@ubergesundheit ubergesundheit deleted the add-capz-provider branch January 15, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gacko Gacko Gacko approved these changes

@erkanerol erkanerol erkanerol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ubergesundheit @kopiczko @Gacko @erkanerol