This repository has been archived by the owner on Dec 23, 2019. It is now read-only.
Add use-forwarded-for to default #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julien Garcia Gonzalez <julien@giantswarm.io>
jgsqware
requested review from
rossf7,
a team and
puja108
and removed request for
a team
|
Yes it should be, but you can test it first |
|
@pipo02mix how I test the PR? |
|
You can use this script |
|
ok tested and it works |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Julien Garcia Gonzalez julien@giantswarm.io
@rossf7 is this enough for setting the default value and let the user modifying if needed?