Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xcoff: add resource test files #4

Merged
merged 4 commits into from
Oct 19, 2022
Merged

xcoff: add resource test files #4

merged 4 commits into from
Oct 19, 2022

Conversation

EsmeYi
Copy link
Contributor

@EsmeYi EsmeYi commented Oct 11, 2022 •
edited
Loading

Add a base test file.

@EsmeYi EsmeYi mentioned this pull request Oct 12, 2022
Merged
philipc
philipc requested changes Oct 12, 2022
View reviewed changes
Copy link
Contributor

@philipc philipc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume base.xcoff is an executable file? Can you also add both an object file (base.o), and add a script base.sh that contains the commands you used to generate these.

@EsmeYi
Copy link
Contributor Author

EsmeYi commented Oct 12, 2022

Addressed comments.

@EsmeYi EsmeYi requested a review from philipc October 12, 2022 16:11
@philipc
Copy link
Contributor

philipc commented Oct 13, 2022

Can you also add 32-bit XCOFF files?

@EsmeYi
Copy link
Contributor Author

EsmeYi commented Oct 13, 2022

Can you also add 32-bit XCOFF files?

Yes. But the 32-bit XCOFF isn't supported in gimli-rs/object#469 now.

@EsmeYi
Copy link
Contributor Author

EsmeYi commented Oct 19, 2022

Added 32-bit XCOFF files.

philipc
philipc approved these changes Oct 19, 2022
View reviewed changes
Copy link
Contributor

@philipc philipc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@philipc philipc merged commit 1f989e6 into gimli-rs:master Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philipc philipc philipc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EsmeYi @philipc