read/coff: improve detection of auxiliary symbols for sections #603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we wrongly excluded section symbols with non-zero values, and wrongly included function symbols with zero values. This also means that we give them correct symbol kind, and that we exclude them from the symbol map. Note that we still don't give the correct symbol kind to section symbols that don't have an auxiliary symbol.
mcbegamerxx954
pushed a commit
to mcbegamerxx954/object
that referenced
this pull request
Jun 15, 2024
…-rs#603) Previously we wrongly excluded section symbols with non-zero values, and wrongly included function symbols with zero values. This also means that we give them the correct symbol kind, and that we exclude them from the symbol map. Note that we still don't give the correct symbol kind to section symbols that don't have an auxiliary symbol.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we wrongly excluded section symbols with non-zero values, and wrongly included function symbols with zero values.
This also means that we give them correct symbol kind, and that we exclude them from the symbol map.
Note that we still don't give the correct symbol kind to section symbols that don't have an auxiliary symbol.