Adding option 'Host' to BinaryFormat enum + new exampel #661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipc
requested changes
Apr 3, 2024
src/write/mod.rs
Outdated
| pub fn new(mut format: BinaryFormat, architecture: Architecture, endian: Endianness) -> Object<'a> { | ||
| if format == BinaryFormat::Host { | ||
| format = format.get(); | ||
| } |
There was a problem hiding this comment.
This change can be deleted after Host is replaced with native_object.
Co-authored-by: Philip Craig <philipjcraig@gmail.com>
Co-authored-by: Philip Craig <philipjcraig@gmail.com>
Co-authored-by: Philip Craig <philipjcraig@gmail.com>
|
Ok i integrated your changes but i renamed |
|
Yes please remove the directory too. Also keep the name as |
|
I fixed it |
philipc
reviewed
Apr 4, 2024
philipc
approved these changes
Apr 4, 2024
mcbegamerxx954
pushed a commit
to mcbegamerxx954/object
that referenced
this pull request
Jun 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I added the enum-varient
Hostto theBinaryFormatenum, which automaticly maps under Windows to Coff on MacOS to Macho and on other platforms to Elf.I also added the translated faerie example (thanks @philipc for the code while he was very nicely helping me out), because i think the exampels which are currently in place, are hard to understand as someone (like me) comming from
faerieBye