Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 2 new constants #720

Merged
merged 3 commits into from
Aug 19, 2024
Merged

Add 2 new constants #720

merged 3 commits into from
Aug 19, 2024

Conversation

marxin
Copy link
Contributor

@marxin marxin commented Aug 18, 2024

philipc
philipc requested changes Aug 19, 2024
View reviewed changes
Copy link
Contributor

@philipc philipc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Can you place them after SHF_MASKOS, and also add them to crates/examples/src/readobj/elf.rs (which I notice is missing SHF_EXCLUDE).

@marxin marxin requested a review from philipc August 19, 2024 05:32
@philipc philipc merged commit 3872c29 into gimli-rs:master Aug 19, 2024
10 checks passed
@marxin marxin deleted the add-new-SHF-constants branch August 19, 2024 05:53
@marxin
Copy link
Contributor Author

marxin commented Aug 19, 2024

Thanks for merging the change. I want to use the change in the wild linker.

Any estimation about a new release of object crate?

@philipc
Copy link
Contributor

philipc commented Aug 19, 2024

No plan for a release, but can do one if needed.

Have you already checked for more missing constants in wild?

@marxin
Copy link
Contributor Author

marxin commented Aug 27, 2024

Please make a release, now I can't see anything particular missing for wild ld.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philipc philipc philipc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marxin @philipc