Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade validator version to v9 #1015

Merged
merged 19 commits into from
Sep 5, 2019
Merged

upgrade validator version to v9 #1015

merged 19 commits into from
Sep 5, 2019

Conversation

thinkerou
Copy link
Member

No description provided.

@appleboy
Copy link
Member

build fail. missing some package.

@cch123
Copy link

cch123 commented Jul 13, 2017

validator removes exists tag from v8 to v9, this update may break some users' apps

@javierprovecho javierprovecho added this to the 1.x milestone Jul 13, 2017
@codecov
Copy link

codecov bot commented Jul 13, 2017

Codecov Report

Merging #1015 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1015   +/-   ##
=======================================
  Coverage   98.69%   98.69%           
=======================================
  Files          40       40           
  Lines        2225     2225           
=======================================
  Hits         2196     2196           
  Misses         16       16           
  Partials       13       13
Impacted Files Coverage Δ
binding/default_validator.go 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3f7fc3...5610fa4. Read the comment docs.

@javierprovecho
Copy link
Member

Please hold this PR, need to clarify if this (#1015) and #990 should be considered breaking and need a major version bump, or a warning in the changelog is ok for a minor version bump (v1.3 milestone)

cc @tboerger @appleboy

@javierprovecho
Copy link
Member

note: review #430 (comment)

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the same example that validator provides, i add to my project and not break

@ashtonian
Copy link

Wondering what the status of this is - does somebody need to submit another PR?

@thinkerou
Copy link
Member Author

@aadidenko nobody, only the pr, waiting for review.

@zwhitchcox
Copy link

Ok, yall, I think we need to prioritize this PR. My users need emojis in their usernames.

@Ianwww
Copy link

Ianwww commented Jul 10, 2018

Is there another way to upgrade to v9 without waiting for this PR to get merged in?

@kishaningithub
Copy link

Validator V9 includes oneof validation which is very much needed for my project

@tomriddle1234
Copy link

oh here it is, mark this one too

@FaithOliviaTKPD
Copy link

FaithOliviaTKPD commented Sep 24, 2018

Any updates on this PR? Validator V9 would be really useful!

@thinkerou
Copy link
Member Author

Maybe we should upgrade milestone v1.4.0, ping @javierprovecho @appleboy thanks!

@rssathe
Copy link

rssathe commented Dec 18, 2018

@thinkerou @appleboy can we get this merged in?

@plo-
Copy link

plo- commented Feb 6, 2019

Any news?

1 similar comment
@always-waiting
Copy link

Any news?

@always-waiting
Copy link

@thinkerou
i am forward to it~

@thinkerou
Copy link
Member Author

@always-waiting sorry, the issue need @javierprovecho review and agree! thanks!

@dmarkham
Copy link
Contributor

@thinkerou what are you thinking in regards to moving forward with v9? We going to merge this or reject it?

@thinkerou
Copy link
Member Author

thinkerou commented May 22, 2019

agree, KISS is best, gin should't not to do complex param check.

I also like KISS, about the pull request we should wait @javierprovecho review as your said #1015 (comment), upgrade to v9 isn't urgent, so we should wait his reply.

appleboy
appleboy previously approved these changes May 23, 2019
@thinkerou
Copy link
Member Author

@appleboy we should merge to gin1.5 branch now? thanks!

@TonyPythoneer
Copy link

@thinkerou Please fix the conflict.

Could it release it as next versions after merging this branch?

In my view, this issue is more important than other. We desire to use the latest validation to enhance current error message readability. To compare other issues in 1.5 milestone, those are bug fix and feature enhancements. It seems it’s not critical for current gin. Those can postpone to future version. To focus simple and important issue, let the PR get merged and the new change get released fast.

In short, we hope the 1.5 or any milestone’s scope could get reduced or classify more and small task. It ensures the release can ship fast to developer.

In personal, I am very expected every new release of gin, we will use the new feature to simplify our development. Thanks.

If other gin fans have any idea, please comment here. I want to know what you expect and discuss here. Thanks.

@souravray
Copy link

The PR still doesn't expose the validator object.
Is there a way to access the validator object, so RegisterValidation method can be called?

@Askadias
Copy link

Askadias commented Sep 4, 2019

Any progress on getting this released?

@appleboy
Copy link
Member

appleboy commented Sep 4, 2019

@thinkerou Please fix the conflict.

@thinkerou
Copy link
Member Author

@appleboy done

@thinkerou
Copy link
Member Author

As #1015 (comment) said, we need to add breaking change log and merge it now, right? @appleboy

@appleboy
Copy link
Member

appleboy commented Sep 5, 2019

@thinkerou Yes, we need to write some changes like features or bug fix in CHANGELOG.md for next release version.

@thinkerou
Copy link
Member Author

@appleboy OK, thanks! merged.

@thinkerou thinkerou merged commit 1acb3fb into gin-gonic:master Sep 5, 2019
ThomasObenaus pushed a commit to ThomasObenaus/gin that referenced this pull request Feb 19, 2020
* upgrade validator version to v9

* Update vendor.json

* Update go.mod

* Update go.sum

* fix

* fix

* fix bug

* Update binding_test.go

* Update validate_test.go

* Update go.sum

* Update go.mod

* Update go.sum

* Update go.mod

* Update go.sum
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.