Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed JSONP format (added semicolon) #2007

Merged
merged 4 commits into from
Sep 2, 2019
Merged

Conversation

gabolaev
Copy link
Contributor

@gabolaev gabolaev commented Aug 5, 2019

According to wiki, JSONP must have a semicolon at the end of javascript expression.

callback_func({"foo": "bar", "baz": 42}); <-

@codecov
Copy link

codecov bot commented Aug 5, 2019

Codecov Report

Merging #2007 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2007   +/-   ##
=======================================
  Coverage   98.69%   98.69%           
=======================================
  Files          40       40           
  Lines        2225     2225           
=======================================
  Hits         2196     2196           
  Misses         16       16           
  Partials       13       13
Impacted Files Coverage Δ
render/json.go 87.34% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ece26c...a6febb6. Read the comment docs.

@appleboy appleboy added the bug label Sep 2, 2019
@appleboy appleboy merged commit 01ca625 into gin-gonic:master Sep 2, 2019
ThomasObenaus pushed a commit to ThomasObenaus/gin that referenced this pull request Feb 19, 2020
* Fixed JSONP format (added semicolon)

* render_test fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants