Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close files opened in static file handler #2118

Merged
merged 3 commits into from
Oct 31, 2019
Merged

Close files opened in static file handler #2118

merged 3 commits into from
Oct 31, 2019

Conversation

Shamus03
Copy link
Contributor

@Shamus03 Shamus03 commented Oct 30, 2019

Fixes #2117

@codecov
Copy link

codecov bot commented Oct 30, 2019

Codecov Report

Merging #2118 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2118      +/-   ##
==========================================
+ Coverage   98.83%   98.83%   +<.01%     
==========================================
  Files          40       40              
  Lines        2231     2233       +2     
==========================================
+ Hits         2205     2207       +2     
  Misses         13       13              
  Partials       13       13
Impacted Files Coverage Δ
routergroup.go 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 517eacb...739b4f8. Read the comment docs.

routergroup.go Outdated Show resolved Hide resolved
@thinkerou thinkerou added this to the 1.5 milestone Oct 31, 2019
@thinkerou thinkerou merged commit aabaccb into gin-gonic:master Oct 31, 2019
ThomasObenaus pushed a commit to ThomasObenaus/gin that referenced this pull request Feb 19, 2020
* Close files opened in static file handler

* Do not use defer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Static file handler does not close files
2 participants