Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Promela #5659

Merged
merged 6 commits into from
Nov 29, 2021
Merged

Conversation

ishowta
Copy link
Contributor

@ishowta ishowta commented Nov 23, 2021

Description

Checklist:

@ishowta ishowta requested a review from a team as a code owner November 23, 2021 20:48
Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usage looks widespread enough for inclusion, however your last two samples aren't examples of real-world representative usage of the language.

Please replace these with real-world files.

@Alhadis
Copy link
Collaborator

Alhadis commented Nov 25, 2021

Please replace these with real-world files.

@lildude I went and collected the samples for him, as it was particularly difficult to find real-world uses that weren't university coursework (and students hardly ever elucidate the license of their assignments… given that that would be kinda weird and all…)

@Alhadis Alhadis changed the title Add support for Promela language Add support for Promela Nov 25, 2021
Source code used in the paper linked from Promela's official website
@ishowta
Copy link
Contributor Author

ishowta commented Nov 25, 2021

I added the source code used in the paper that was linked from the official Promela website.

@Alhadis
Copy link
Collaborator

Alhadis commented Nov 25, 2021

I added the source code used in the paper that was linked from the official Promela website.

Can you confirm this was released under a license that permits redistribution? Though Linguist's licensing requirements are less strict for language samples than they are for grammars, we still need to assert that these samples aren't copyrighted (non-free) material.

@ishowta
Copy link
Contributor Author

ishowta commented Nov 25, 2021

These source codes are under the Apache 2.0 license (added to the checklist).

Thread.pml, Supervisor.pml, Session.pml: Apache 2.0

@Alhadis
Copy link
Collaborator

Alhadis commented Nov 25, 2021

@ishowta What do you think about using #de0000 for the language colour? I couldn't find any logos or branding related to Promela at all, but the program it's interpreted by certainly does:

@ishowta
Copy link
Contributor Author

ishowta commented Nov 26, 2021

I couldn't find the Promela logo either, but I think its color is good.

@lildude lildude merged commit 5cf7ab4 into github-linguist:master Nov 29, 2021
kalkin added a commit to kalkin/file-expert that referenced this pull request May 9, 2022
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants