Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Procfile language #5760

Merged
merged 6 commits into from
Feb 9, 2022
Merged

Add Procfile language #5760

merged 6 commits into from
Feb 9, 2022

Conversation

Nixinova
Copy link
Contributor

@Nixinova Nixinova commented Feb 3, 2022

Description

Adds the Procfile filename/language used in Heroku web apps.

Colour #3B2F63 from topbar in Heroku docs

Type is programming, but data might be better? It's a list of commands of format name: cmd with --args.

Checklist:

  • I am adding a new language.
    • The extension of the new language is used in hundreds of repositories on GitHub.com.
      • Search results for each extension:
    • I have included a real-world usage sample for all extensions added in this PR:
    • I have included a syntax highlighting grammar:
    • I have updated the heuristics to distinguish my language from others using the same extension.

@Nixinova Nixinova requested a review from a team as a code owner February 3, 2022 00:18
Copy link
Contributor

@blockarchitech blockarchitech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Procfile is indeed used in thousands of repositories across GitHub, so I don't see why this wouldn't be added.

@Nixinova Nixinova mentioned this pull request Feb 4, 2022
@Alhadis
Copy link
Collaborator

Alhadis commented Feb 4, 2022

Type is programming, but data might be better? It's a list of commands of format name: cmd with --args.

Makefiles are composed of similar declarations, and since we categorise those as programming, I'd say the current designation is appropriate. 👍

@lildude lildude merged commit c90e238 into github-linguist:master Feb 9, 2022
kalkin added a commit to kalkin/file-expert that referenced this pull request May 17, 2022
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proposal: Procfile language
5 participants