-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add language: Sweave #6544
Add language: Sweave #6544
Conversation
Questionable if the |
Not 😄 It doesn't meet our popularity requirements by a large margin. An override can always be used once this PR have been merged and deployed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove or replace samples/Sweave/Sweave.Rnw
with a smaller sample as the current sample is unnecessarily large (if it's not displayed in the diff by default, it's generally too big).
Removed .snw extension from languages.yml and deleted related .snw sample file. As far as heuristics go, the unique features of the language that I can think of are
|
Don't worry about the heuristics… as you've pointed out this is the only user of that extension and a quick search suggests this isn't likely to cause problems. You will however need to address the test failures. |
Setting ace_mode to tex, since a .tex file is a valid .Rnw as well.
I addressed the ace_mode fail, but the request to run a script will need to wait until tomorrow. Dev machine is in the office. I set ace_mode to tex, on the basis that a valid .tex file is also valid .Rnw. |
Done it for you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good now. Thanks.
Description
resolves #6538
A prose language for literate programming with the R statistical software language. Precursor to Rmarkdown, a supported language. Mixes R code with TeX documentation. Present in documentation of many R language repositories.
Checklist:
#198ce7