-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BigInt Documentation #17556
base: main
Are you sure you want to change the base?
BigInt Documentation #17556
Conversation
25543f3
to
c303137
Compare
c303137
to
2b06dfc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an initial review just for cosmetics.
string provenance | ||
); | ||
|
||
An extensible predicate is a CodeQL predicate with the following restrictions: | ||
|
||
- It uses the ``extensible`` keyword. | ||
- It has no body. | ||
- All predicate parameters have primitive types. | ||
- All predicate parameters have type `string`, `int`, `float`, `boolean`, or `date`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- All predicate parameters have type `string`, `int`, `float`, `boolean`, or `date`. | |
- All predicate parameters have type ``string``, ``int``, ``float``, ``boolean``, or ``date``. |
|
||
The other built-in operations are: | ||
|
||
* comparisons between :code:`BigInt`s: :code:`=`, :code:`!=`, :code:`<`, :code:`<=`, :code:`>`, :code:`>=`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GitHub's built-in RST renderer gets the quoting wrong in :code:`BigInt`s
. I don't know if you'll see the same in our rendered documentation. I'm sure there's a way to preview it, but I don't know how.
This type is not available in the CodeQL CLI by default, but you can enable it by passing the ``--allow-experimental=bigint`` | ||
option to the CodeQL CLI. Consequently, queries are currently restricted from returning BigInts as results. | ||
|
||
Unlike :code:`int` and :code:`float`, there is no automatic conversion between :code:`BigInt` and other numeric types. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why use :code:
here but double backticks above?
* bitwise operations: :code:`.bitAnd(BigInt)`, :code:`.bitOr(BigInt)`, | ||
:code:`.bitXor(BigInt)`, :code:`.bitShiftLeft(int)`, :code:`.bitShiftRightSigned(int)`, | ||
:code:`.bitNot()`, | ||
* aggregates: :code:`min`, :code:`max`, (:code:`strict`):code:`sum`, (:code:`strict`):code:`count`, :code:`avg`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The rendering is also wrong around the (:code:`strict`)
notation.
This PR introduces public-facing documentation around the experimental
QlBuiltins::BigInt
type.Commits
Questions