Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C++: Add more macro expansion tests #17608

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jketema
Copy link
Contributor

@jketema jketema commented Sep 27, 2024

Observe that these changes demonstrate that checking for expansions currently doesn't completely work as one might expect. I currently don't plan to fix this, was just noticing that we were missing some test coverage here.

Pull Request checklist

All query authors

Internal query authors only

  • Autofixes generated based on these changes are valid, only needed if this PR makes significant changes to .ql, .qll, or .qhelp files. See the documentation (internal access required).
  • Changes are validated at scale (internal access required).
  • Adding a new query? Consider also adding the query to autofix.

@github-actions github-actions bot added the C++ label Sep 27, 2024
@jketema jketema force-pushed the macro-expansion-tests branch 2 times, most recently from ed706db to cef8f03 Compare September 28, 2024 11:19
@jketema jketema marked this pull request as ready for review September 30, 2024 08:37
@jketema jketema requested a review from a team as a code owner September 30, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant