Brodes/wcharcharconversion false positives upstream5 #17611
+140
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jketema Let me know if these commits give you what you need. I did screw something up, and failed to have my first commit stipulate explicitly the false positives in the test case, they were just marked 'GOOD'. I'll try to mark them explicitly for future PRs though. |
…oid cases where unsigned char is the default char width for `char`.
|
I believe I got all the comments. Is the protocol that I resolve them? |
![github-advanced-security[bot]](https://avatars.github.com/in/57789?s=60&v=4){kind=small}
jketema
reviewed
Sep 30, 2024
cpp/ql/src/change-notes/2024-09-26-wcharcharconversion-false-positives.md
Outdated
Show resolved
Hide resolved
There's no real protocol. I've marked them as resolved. |
…ositives.md Co-authored-by: Jeroen Ketema <93738568+jketema@users.noreply.github.com>
…https://github.com/microsoft/codeql into brodes/wcharcharconversion_false_positives_upstream5
|
I think you need to auto-format the ql file |
Fixed. |
|
Thanks. I'll kick-off a DCA experiment. If that looks good, we can merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing false positives with byte arrays. There was an existing check for byte arrays, but there were cases missed. Updated and cleaned up this logic and added test cases to expose the observed false positive.
Also addressed false positives due to types based on macro definitions, and then dynamic checks are used to determine if dangerous widening is performed at runtime. Test cases added to demonstrate the style of check.