Go: Make the models-as-data subtypes column do something more sensible for promoted methods #17618
+152
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.github.com/in/57789?s=60&v=4){kind=small}
| subtypes = true and | ||
| // p.type is an interface and we include types which implement it | ||
| exists(Method m2, string pkg2, string type2 | | ||
| subtypes = true and |
Check warning
Code scanning / CodeQL
Redundant assignment. Warning
| cn = this.asCall().getNode() and | ||
| result.asEntity() = cn.getTarget() and | ||
| // result.asEntity().getName() = "Source" and | ||
| cn = this.asCall().getNode() and |
Check warning
Code scanning / CodeQL
Redundant assignment. Warning
| * field at depth `fieldDepth` which is on the chain of embedded fields which | ||
| * leads to `m` being promoted, and the type of the field is `pkg.name`. | ||
| */ | ||
| private predicate receiverInfoHelper( |
Check warning
Code scanning / CodeQL
Missing QLDoc for parameter Warning
Comment on lines
+325
to
+335
| depth = 1 and | ||
| embeddedParent = st.getOwnField(_, true) and | ||
| embeddedParent.getType().hasQualifiedName(pkg, name) | ||
| or | ||
| depth > 1 and | ||
| exists(Type embeddedType, StructType st2 | | ||
| st.hasOwnField(_, _, embeddedType, true) and | ||
| st2 = embeddedType.getUnderlyingType() and | ||
| m = st2.getMethodOfEmbedded(embeddedParent, _, depth - 1) and | ||
| receiverInfoHelper(m, embeddedParent, st2, depth - 1, pkg, name) | ||
| ) |
Check warning
Code scanning / CodeQL
Var only used in one side of disjunct. Warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not ready for review yet. I think I've fixed all the spurious test results. I'm going to run DCA to see how this affects alerts.
To do: