Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addressed #21207 #21294

Merged
merged 4 commits into from
Oct 12, 2022
Merged

Addressed #21207 #21294

merged 4 commits into from
Oct 12, 2022

Conversation

ujjwal-shekhar
Copy link
Contributor

@ujjwal-shekhar ujjwal-shekhar commented Oct 12, 2022

Updated the documentation to account for issue : #21207

Why:

Closes #21207

What's being changed (if available, include any code snippets, screenshots, or gifs):

I have added a one-line clarification and added examples of when the Label won't render as usual. The change was made in the Labels section.

Check off the following:

  • I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
  • For content changes, I have completed the self-review checklist.

Updated the documentation to account for issue : github#21207
@welcome
Copy link

welcome bot commented Oct 12, 2022

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Oct 12, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 12, 2022

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
get-started/writing-on-github/working-with-advanced-formatting/autolinked-references-and-urls.md fpt
ghec
ghes@ 3.6 3.5 3.4 3.3 3.2
ghae
fpt
ghec
ghes@ 3.6 3.5 3.4 3.3 3.2
ghae

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server
ghae: GitHub AE

@cmwilson21
Copy link
Contributor

@ujjwal-shekhar Thanks so much for opening a PR! I've edited your post slightly so it links to the issue.

I'll get this triaged for review ⚡

@cmwilson21 cmwilson21 added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review get started Content related to "Getting Started" doc set and removed triage Do not begin working on this issue until triaged by the team labels Oct 12, 2022
@sabrowning1 sabrowning1 self-requested a review October 12, 2022 18:05
Copy link
Contributor

@sabrowning1 sabrowning1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ujjwal-shekhar, thanks for your help maintaining our docs! 💛 I made a few small styling edits and will get this merged now 🎉

@sabrowning1 sabrowning1 merged commit 0d803f5 into github:main Oct 12, 2022
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

@sabrowning1 sabrowning1 added hacktoberfest-accepted We might not merge this PR before Nov 1st, but it's a wonderful Hacktoberfest contribution! and removed waiting for review Issue/PR is waiting for a writer's review labels Oct 12, 2022
@ujjwal-shekhar ujjwal-shekhar deleted the patch-1 branch October 25, 2022 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team get started Content related to "Getting Started" doc set hacktoberfest-accepted We might not merge this PR before Nov 1st, but it's a wonderful Hacktoberfest contribution!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Labels with periods do not render
4 participants