Fix handling of URLs in Harmony datasets #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The 5.1.10.9-gs builds of Bio-Formats on the private download page now include these changes; the OMERO builds will be updated once the changes are approved and the pull request is merged. |
|
changes look alright to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves the issue reported in #3.
Without this change,
showinf Oris-Pro_100914__2010-09-14T17_11_35-Measurement1/Images/Index.ref.xml(or opening in ImageJ) should result in the exception shown in the original issue. With this change, the same test should result in correct images being displayed. Images can be compared for correctness either by opening the local TIFF files individually (selecting the.tiffinstead ofIndex.ref.xmlin showinf/ImageJ), or editingIndex.ref.xmlto point to the file paths on disk.