Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bold does not get bold (same for italic) #1558

Closed
igr opened this issue Jun 21, 2023 · 5 comments
Closed

Bold does not get bold (same for italic) #1558

igr opened this issue Jun 21, 2023 · 5 comments
Assignees

Comments

@igr
Copy link

igr commented Jun 21, 2023

Description

The following example:

**Development approach**:

does not get bold:

CleanShot 2023-06-21 at 08 12 35

but this works (space added before the :):

**Development approach** :

CleanShot 2023-06-21 at 08 15 02

To Reproduce

Type **foo**: hello

Expected behavior

UI should make text bold (or italic)

FSNotes version

Version 6.3.3 (578)

macOS/iOS version

latest

Additional context

No response

@gingerbeardman
Copy link
Collaborator

gingerbeardman commented Jun 21, 2023

Markdown is handled by a library, Markdown.swift which uses libcmark_gfm which is the stringent CommonMark spec.

You can try it here: https://spec.commonmark.org/dingus/

And if the problem still exists it will be because of CommonMark.

@igr
Copy link
Author

igr commented Jun 21, 2023

@gingerbeardman It works on the dingus example:

CleanShot 2023-06-21 at 23 50 16

@gingerbeardman
Copy link
Collaborator

gingerbeardman commented Jun 22, 2023

Great! Then over to @glushchenko when he returns

Bug is likely in this function:

public static func highlightMarkdown(attributedString: NSMutableAttributedString, paragraphRange: NSRange? = nil, note: Note) {

glushchenko added a commit that referenced this issue Jul 13, 2023
@glushchenko
Copy link
Owner

@gingerbeardman exactly :)
@igr thank you for report, fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants