Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Faster archiving methods #234

Merged
merged 11 commits into from
Jul 16, 2018
Merged

Faster archiving methods #234

merged 11 commits into from
Jul 16, 2018

Conversation

github0013
Copy link
Contributor

@github0013 github0013 commented Oct 5, 2016 •
edited
Loading

mailbox('[Gmail]/All Mail') can be deadly slow when you have full of emails.
This will fix that by

  1. create a temp folder (label)
  2. put the target email in it
  3. archive it or unarchive it
  4. delete the temp folder

ore added 11 commits September 29, 2016 11:34
fixes Net::IMAP::BadResponseError: Could not parse command
979eb53
change Month format
436e008
add #find
327aabd
add message_id option
a3929bf
fix #move_to
cef8aeb
fix #archive! and #unarchive!
e159dc4
change archiving methods
68c3044 
when you have significantly large amounts of emails,
mailbox('[Gmail]/All Mail')
will be deadly slow.

create a temp folder(label) and put the target email in it, and finding it by message_id within will be much faster.
fix error class name
b654a1a
revert
a78ee6e
Revert "add message_id option"
9ed4fd8 
This reverts commit a3929bf.
change #find to use rfc822msgid gmail search operator
d4d201e
@github0013
Copy link
Contributor Author

found better way rather than creating dummy folders around.
https://support.google.com/mail/answer/7190?hl=en

#find is still slow, but I think this is a better approach.

@johnnyshields
Copy link
Contributor

I don't think Base is the right class to implement the find method. It seems Mailbox has a very similar method, can you consider that approach.

@johnnyshields johnnyshields mentioned this pull request Jan 27, 2017
Closed
@github0013
Copy link
Contributor Author

@johnnyshields

Mailbox seems to be the right place, but I think it's tied to a Gmail's label as a mailbox.
It's in Base#findbecause it uses rfc822msgid over all labels.
github0013@d4d201e#diff-0fe1a6da51e462184e7052479dfb126aR195

@johnnyshields johnnyshields merged commit bdd5983 into gmailgem:master Jul 16, 2018
@johnnyshields johnnyshields mentioned this pull request Jul 16, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@github0013 @johnnyshields