Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Agsdoc new style #430

Merged
merged 3 commits into from
Aug 8, 2024
Merged

Agsdoc new style #430

merged 3 commits into from
Aug 8, 2024

Conversation

rmottola
Copy link
Member

@rmottola rmottola commented Aug 7, 2024

Improvements to AutoGSDoc to enhance CSS styling and HTML5 compatibility

@rmottola rmottola requested a review from rfm as a code owner August 7, 2024 15:19
@rmottola
Copy link
Member Author

rmottola commented Aug 7, 2024

@rfm not yet done keeping this open for further improvements, but so we can comment and collaborate on it and comment & keep track. When you feel enough we can merge.
We could also add Frame work on this branch

@rmottola
Copy link
Member Author

rmottola commented Aug 7, 2024

@rfm I found that the main .html is declared as xhtml and uses XHTML styles in a mix with HTML. I think that is a little strange, especially today, would you agree to cleanup to HTML?

Copy link
Contributor

@rfm rfm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those changes all look good, but I expect you will need to rebase because I committed other changes to implement basic graphing of class/superclass using graphviz.

@rfm
Copy link
Contributor

rfm commented Aug 7, 2024 via email

@rfm
Copy link
Contributor

rfm commented Aug 7, 2024

I didn't see this branch until after committing autogsdoc graphing changes. Perhaps I should do further changes here?

@rmottola
Copy link
Member Author

rmottola commented Aug 8, 2024

@rfm there are no merge conflicts, so we were lucky, since it is one specific change I think it can go in, I merged.
Best to make a new common branch for style improvements!

@rmottola rmottola merged commit ea9c40e into master Aug 8, 2024
8 of 10 checks passed
@rmottola rmottola deleted the agsdoc_new_style branch August 8, 2024 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants