Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move tests as seperate sub packages to reduce duplicated file names #19951

Merged
merged 11 commits into from
Jun 15, 2022
Merged

Move tests as seperate sub packages to reduce duplicated file names #19951

merged 11 commits into from
Jun 15, 2022

Conversation

lunny
Copy link
Member

@lunny lunny commented Jun 13, 2022

No description provided.

@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Jun 13, 2022
silverwind
silverwind reviewed Jun 14, 2022
View reviewed changes
models/consistency.go Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 14, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jun 15, 2022 •
edited
Loading

Codecov Report

Merging #19951 (330f442) into main (0097fbc) will increase coverage by 0.08%.
The diff coverage is 42.71%.

@@            Coverage Diff             @@
##             main   #19951      +/-   ##
==========================================
+ Coverage   47.29%   47.37%   +0.08%     
==========================================
  Files         966      967       +1     
  Lines      134117   134126       +9     
==========================================
+ Hits        63424    63539     +115     
+ Misses      62977    62866     -111     
- Partials     7716     7721       +5
Impacted Files Coverage Δ
cmd/cmd.go 40.74% <0.00%> (ø)
cmd/migrate_storage.go 0.00% <0.00%> (ø)
cmd/serv.go 2.22% <0.00%> (ø)
models/consistency.go 34.78% <ø> (+22.62%) ⬆️
models/db/context.go 70.10% <ø> (ø)
models/db/list_options.go 63.63% <ø> (ø)
models/error.go 38.66% <ø> (+2.79%) ⬆️
models/git/lfs_lock.go 41.96% <ø> (ø)
models/git/protected_tag.go 67.64% <ø> (ø)
models/issues/assignees.go 68.57% <ø> (ø)
... and 202 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6e2dba...330f442. Read the comment docs.

wxiaoguang
wxiaoguang approved these changes Jun 15, 2022
View reviewed changes
Copy link
Contributor

@wxiaoguang wxiaoguang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The moving is fine. My question is how does it "reduce duplicated file names"?

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 15, 2022
@lunny
Copy link
Member Author

lunny commented Jun 15, 2022

The moving is fine. My question is how does it "reduce duplicated file names"?

By removing many test functions from models to sub pacakges, so some test files could be deleted.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 15, 2022
@6543 6543 merged commit d91d4db into go-gitea:main Jun 15, 2022
@lunny lunny deleted the lunny/move_tests_file branch June 15, 2022 11:50
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jun 16, 2022
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
bec4d38 
* giteaofficial/main:
  Allow render HTML with css/js external links (go-gitea#19017)
  Use correct count for `NumOpenIssues` (go-gitea#19980)
  In code search, get code unit accessible repos in one (main) query (go-gitea#19764)
  [skip ci] Updated translations via Crowdin
  Always try to fetch repo for mirrors (go-gitea#19975)
  Remove tab/TabName usage where it's not needed (go-gitea#19973)
  Fix cli command restore-repo: "units" should be parsed as StringSlice (go-gitea#19953)
  Uppercase first languages letters (go-gitea#19965)
  Move tests as seperate sub packages to reduce duplicated file names (go-gitea#19951)
  Replace unstyled meter with progress (go-gitea#19968)
  [skip ci] Updated translations via Crowdin
  [skip ci] Updated translations via Crowdin
  Remove singuliere from MAINTAINERS (go-gitea#19883)
  Fix aria for logo (go-gitea#19955)
  Fix mirror template bug (go-gitea#19959)
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 24, 2022
@lunny @AbdulrhmnGhanem
Move tests as seperate sub packages to reduce duplicated file names (g…
0f7c679 
…o-gitea#19951)
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@silverwind silverwind silverwind left review comments

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@6543 6543 6543 approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality. type/testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@lunny @codecov-commenter @silverwind @wxiaoguang @6543 @GiteaBot