Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize NuGet package version on upload (#22186) #22200

Merged
merged 2 commits into from
Dec 21, 2022

Conversation

KN4CK3R
Copy link
Member

@KN4CK3R KN4CK3R commented Dec 21, 2022

Backport of #22186

Fixes go-gitea#22178

After this change upload versions with different semver metadata are
treated as the same version and trigger a duplicated version error.

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Dec 21, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 21, 2022
@jolheiser
Copy link
Member

🎺 🤖

@jolheiser jolheiser merged commit f7258aa into go-gitea:release/v1.18 Dec 21, 2022
@KN4CK3R KN4CK3R deleted the backport-86ace4b-18 branch December 21, 2022 21:09
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/packages type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants