Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect checkbox behaviors in the dashboard repolist's filter (#23147) #23205

Merged
merged 2 commits into from
Mar 2, 2023

Commits on Mar 1, 2023

  1. Fix incorrect checkbox behaviors in the dashboard repolist's filter (g…

    …o-gitea#23147)
    
    Co-author: yp05327 , this PR is based on yp05327's go-gitea#22813.
    
    The problems of the old DashboardRepoList / repolist.tmpl: 
    
    * It mixes many different frameworks together
    * It "just works", bug on bug
    * It uses many anti-pattern of Vue
    
    This PR:
    
    * Fix bugs and close go-gitea#22800
    * Decouple the "checkbox" elements from Fomantic UI (only use CSS
    styles)
    * Simplify the HTML layout
    * Simplify JS logic
    * Make it easier to refactor the DashboardRepoList into a pure Vue
    component in the future.
    
    ### Screenshots
    
    #### Default
    
    ![image](https://user-images.githubusercontent.com/2114189/221355768-a3eb5b23-85b4-4e3d-b906-844d8b15539d.png)
    
    ####  Click "Archived" to make it checked
    
    ![image](https://user-images.githubusercontent.com/2114189/221355777-9a104ddf-52a7-4504-869a-43a73827d802.png)
    
    ####  Click "Archived" to make it intermediate
    
    ![image](https://user-images.githubusercontent.com/2114189/221355802-0f67a073-67ad-4e92-84a6-558c432103a5.png)
    
    ####  Click "Archived" to make it unchecked
    
    ![image](https://user-images.githubusercontent.com/2114189/221355810-acf1d9d8-ccce-47fe-a02e-70cf4e666331.png)
    
    ---------
    
    Co-authored-by: yp05327 <576951401@qq.com>
    Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
    3 people authored and GiteaBot committed Mar 1, 2023
    Configuration menu
    Copy the full SHA
    ede3d77 View commit details
    Browse the repository at this point in the history

Commits on Mar 2, 2023

  1. Configuration menu
    Copy the full SHA
    24ce673 View commit details
    Browse the repository at this point in the history