Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixing up postgres connection strings #96

Merged

Conversation

masterkidan
Copy link
Contributor

This is to fix issue #95

@go-jet
Copy link
Owner

go-jet commented Sep 22, 2021

Could you open PR for develop branch. There are some changes made in generator that does not exist on master.
-dsn flag was added with #89.
I guess we could still replace flags with connection string for this function.

@masterkidan masterkidan changed the base branch from master to develop September 22, 2021 17:37
@masterkidan
Copy link
Contributor Author

Updated to develop (hopefully I updated the above correctly).

@go-jet
Copy link
Owner

go-jet commented Sep 23, 2021

LGTM, but it seems there are some rebase conflicts.

@masterkidan
Copy link
Contributor Author

Can you clarify where the conflicts are? I don't see them in the diff.

@go-jet
Copy link
Owner

go-jet commented Sep 24, 2021

It is probably because of merge commit a5c3d54. But it is ok, squash and merge will work as well.

@go-jet go-jet merged commit a85eafd into go-jet:develop Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants