-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ValidateName to CompositeError #32
Conversation
Added a ValidateName method to CompositeError to mirror the same API in Validation type to enable generated validation logic to alias CompositeErrors the same wait it aliases Validations. Signed-off-by: Ben Randall <ben.randall@unity3d.com>
I took a closer look at this and I'm not sure that it'll do what I'm expecting it to do. I turns out that My quick overview of some subset of the code we have that's generated using |
Added a change showing how I would expect it to actually work. Note that the tests have not been updated at the moment so they'll still fail because they're written according to the existing behavior. |
@casualjim - Where's the right place to discuss something like this to get sign-off? |
This PR is still marked as draft, so I can't review it |
Hey @casualjim - I see this was merged to unblock youyuanwu. I don't remember if I ever updated the tests to pass with this change. I was waiting for some feedback around if we thought this was a reasonable solution before fixing the tests but forgot to follow up with you to ask again. I haven't tried running the tests in a while though, so I'm not aware what the current state is. |
ic, we can still update the tests. I merged the change into go-swagger master so I had to bring this one along |
One thought I had though is that we should just typecheck based on an interface instead of typeswitching but thats in the go-swagger repo |
This fixes the tests for the go-openapi#32 PR, which did not update them to match the implementation changes.
This fixes the tests for the go-openapi#32 PR, which did not update them to match the implementation changes. Signed-off-by: Guillem Jover <gjover@sipwise.com>
This fixes the tests for the go-openapi#32 PR, which did not update them to match the implementation changes. Signed-off-by: Guillem Jover <gjover@sipwise.com>
Added a ValidateName method to CompositeError to mirror the same API in Validation type to enable generated validation logic to alias CompositeErrors the same wait it aliases Validations.
Fixes #31