Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix --load-cookies not works #43

Merged
merged 3 commits into from
Nov 19, 2022

Conversation

waybackarchiver
Copy link
Collaborator

Cookies in Request does not work, so it is documented as deprecated, and adding the WithCookies method to attach cookies to Archiver.cookies may be a more reasonable solution, if you have a better way, please share it.

Fix #8

Copy link
Contributor

@RadhiFadlillah RadhiFadlillah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@RadhiFadlillah RadhiFadlillah merged commit 23c015a into go-shiori:master Nov 19, 2022
@waybackarchiver waybackarchiver deleted the fix-cookies branch November 20, 2022 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--load-cookies doesn't appear to do anything
2 participants