fix: templates on task descriptions #1343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blackjid
commented
Sep 21, 2023
| g.Go(func() error { | ||
| compiledTask, err := e.FastCompiledTask(taskfile.Call{Task: task.Task}) | ||
| if err == nil { | ||
| task = compiledTask | ||
| } | ||
| task = compiledTask | ||
| tasks[idx] = compiledTask |
There was a problem hiding this comment.
I'm not sure if there is any problem by modifying the tasks slice from the go subroutines.. All tests passed on my local machine
There was a problem hiding this comment.
We'll never be accessing a map entry from more than one goroutine, so I think this fine.
blackjid
commented
Sep 22, 2023
| @@ -458,13 +458,14 @@ func (e *Executor) GetTaskList(filters ...FilterFunc) ([]*taskfile.Task, error) | |||
|
|
|||
| // Compile the list of tasks | |||
| for i := range tasks { | |||
| task := tasks[i] | |||
| idx := i | |||
| task := tasks[idx] | |||
| g.Go(func() error { | |||
| compiledTask, err := e.FastCompiledTask(taskfile.Call{Task: task.Task}) | |||
There was a problem hiding this comment.
I also think that this err could be just _ and remove the if that follows..
pd93
approved these changes
Oct 3, 2023
|
Thanks @blackjid! |
andreynering
added a commit
that referenced
this pull request
Oct 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
When a task description has uses templates, they are not properly compiled when listing the tasks.
This was reported back in #276 and then fixed in #283
I think then there was a regression in f22389a
I don't have much experience in go and in this project context, I've tried my best to find the real issue.