Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(remote): replace env variable in include remote URL #1610

Merged
merged 3 commits into from
Apr 29, 2024

Conversation

vmaerten
Copy link
Member

I've added the support of env variable in include remote. All env variable presents in the URL (${ENV}) will be replaced.

Related to : #1420 (reply in thread)

@vmaerten vmaerten force-pushed the feat/replace-env-in-include branch from 3ec54bf to 5aaf6b2 Compare April 29, 2024 09:08
@vmaerten vmaerten force-pushed the feat/replace-env-in-include branch from 5aaf6b2 to 5427609 Compare April 29, 2024 09:11
@vmaerten vmaerten requested a review from pd93 April 29, 2024 09:13
Copy link
Member

@pd93 pd93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for this! 👍

@pd93 pd93 merged commit c81dbda into go-task:main Apr 29, 2024
13 checks passed
pd93 added a commit that referenced this pull request Apr 29, 2024
@vmaerten vmaerten deleted the feat/replace-env-in-include branch July 7, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants