Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(client): retry internal retryable errors #171

Merged
merged 13 commits into from
Jul 20, 2024
Merged

feat(client): retry internal retryable errors #171

merged 13 commits into from
Jul 20, 2024

Conversation

go-to-k
Copy link
Owner

@go-to-k go-to-k commented Jul 17, 2024 •
edited
Loading

DeleteObjects often returns output.Errors instead of err. It often has an retryable error, so cls3 should retry the deletion.

Code: InternalError
Key: 1548_994_6279.txt
VersionId: xp.ZtEsKtzzwfqLPC75295nve4FUBshZ
Message: We encountered an internal error. Please try again.

Code: InternalError
Key: 1549_92_24844.txt
VersionId: 68q3pjHpAIee6NS3hh0SKwFPFY0G2xNh
Message: We encountered an internal error. Please try again.

Code: InternalError
Key: 1593_161_10029.txt
VersionId: a8UmOuU4smKnTUpNWs4oKx2QeJt1dsmG
Message: We encountered an internal error. Please try again.

@go-to-k go-to-k changed the title fix(client): retryable internal error often occurs feat(client): retry internal retryable errors Jul 18, 2024
go-to-k
go-to-k commented Jul 18, 2024
View reviewed changes
pkg/client/s3_test.go Outdated Show resolved Hide resolved
@go-to-k go-to-k self-assigned this Jul 19, 2024
@go-to-k go-to-k merged commit 4436bc2 into main Jul 20, 2024
1 check passed
@go-to-k go-to-k deleted the fix/retry-internal-error branch July 20, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@go-to-k go-to-k

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@go-to-k