ci: add linter

.github/workflows/ci.yml

@@ -47,3 +47,19 @@ jobs:
         with:
           name: code-coverage-report
           path: cover.html
+
+  reviewdog:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v4
+      - name: lint
+        uses: reviewdog/action-golangci-lint@v2
+        with:
+          go_version_file: go.mod
+          github_token: ${{ secrets.GITHUB_TOKEN }}
+          reporter: github-pr-review
+          level: error 
+          filter_mode: nofilter
+          golangci_lint_flags: "--config=.golangci.yml"
+          fail_on_error: true

.golangci.yml

@@ -0,0 +1,22 @@
+linters-settings:
+  govet:
+    enable:
+      - shadow
+
+linters:
+  disable-all: true
+  enable:
+    - staticcheck
+    - gofmt
+    - govet
+    - gocritic
+    - unused
+    - errcheck
+    - gosimple
+    - typecheck
+    - misspell
+    - goimports
+    - gosec
+    - ineffassign
+    - unconvert
+    - unparam

.vscode/settings.json

@@ -15,4 +15,8 @@
             "shadow": true
         }
     },
+    "go.lintTool": "golangci-lint",
+    "go.lintFlags": [
+        "--fast"
+    ],
 }

Makefile

@@ -30,6 +30,10 @@ test_view:
 	rm cover.out.tmp
 	go tool cover -func=cover.out
 	go tool cover -html=cover.out -o cover.html
+lint:
+	golangci-lint run
+lint_diff:
+	golangci-lint run $$(echo $(DIFF_FILE))
 mockgen:
 	go generate ./...
 shadow:

internal/app/app.go

@@ -151,6 +151,7 @@ func (a *App) getAction() func(c *cli.Context) error {
 			}
 
 			for _, bucket := range buckets {
+				//nolint:errcheck
 				a.BucketNames.Set(bucket)
 			}
 		}

internal/io/input.go

@@ -19,6 +19,7 @@ func GetCheckboxes(label string, opts []string) []string {
 		Options:  opts,
 		PageSize: SelectionPageSize,
 	}
+	//nolint:errcheck
 	survey.AskOne(prompt, &res, survey.WithKeepFilter(true))
 
 	return res

pkg/client/retryer.go

@@ -35,6 +35,7 @@ func (r *Retryer) MaxAttempts() int {
 func (r *Retryer) RetryDelay(int, error) (time.Duration, error) {
 	waitTime := 1
 	if r.delayTimeSec > 1 {
+		//nolint:gosec
 		waitTime += rand.IntN(r.delayTimeSec)
 	}
 	return time.Duration(waitTime) * time.Second, nil

pkg/client/s3_test.go

@@ -21,6 +21,7 @@ func getTokenForListDirectoryBucketsInitialize(
 ) (
 	out middleware.InitializeOutput, metadata middleware.Metadata, err error,
 ) {
+	//nolint:gocritic
 	switch v := in.Parameters.(type) {
 	case *s3.ListDirectoryBucketsInput:
 		ctx = middleware.WithStackValue(ctx, tokenForListDirectoryBuckets{}, v.ContinuationToken)
@@ -35,6 +36,7 @@ func setTargetObjectsForDeleteObjectsInitialize(
 ) (
 	out middleware.InitializeOutput, metadata middleware.Metadata, err error,
 ) {
+	//nolint:gocritic
 	switch v := in.Parameters.(type) {
 	case *s3.DeleteObjectsInput:
 		ctx = middleware.WithStackValue(ctx, targetObjectsForDeleteObjects{}, v.Delete.Objects)