Add optional initial transition #492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow the state machine to track the initial state for the machine, this is important for 3 reasons: - It allows us to keep a record of how long the state machine spent in the initial state - If the initial state configuration changes after the state machine transitions from the initial state we still have an accurate record of what the initial state was - If the initial state configuration changes before the state machine transitions from the initial state we still have an accurate record of what the initial state is
dylan-hoefsloot
commented
Feb 22, 2023
| expect { check_missing_methods! }.to_not raise_exception(NotImplementedError) | ||
| expect { check_missing_methods! }.to_not raise_exception |
There was a problem hiding this comment.
WARNING: Using `expect { }.not_to raise_error(SpecificErrorClass)` risks false positives, since literally any other error would cause the expectation to pass, including those raised by Ruby (e.g. NoMethodError, NameError and ArgumentError), meaning the code you are intending to test may not even get reached. Instead consider using `expect { }.not_to raise_error` or `expect { }.to raise_error(DifferentSpecificErrorClass)`.
Tabby
reviewed
Mar 14, 2023
Tabby
approved these changes
Mar 16, 2023
|
@Tabby Any chance we get this merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow the state machine to track the initial state for the machine, this is important for 4 reasons: