Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(guardrail): support one-sided test #61

Merged
merged 6 commits into from
Oct 31, 2022
Merged

feat(guardrail): support one-sided test #61

merged 6 commits into from
Oct 31, 2022

Conversation

xyzou685
Copy link
Contributor

@xyzou685 xyzou685 commented Oct 21, 2022

This PR combines #46 , #58 and #57

To help us get this pull request reviewed and merged quickly, please be sure to include the following items:

  • Tests (if applicable)
  • Documentation (if applicable)
  • A full explanation here in the PR description of the work done and statistical methods used

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

Backward Compatibility

Is this change backward compatible with the most recently released version? Does it introduce changes which might change the user experience in any way? Does it alter the API in any way?

  • Yes (backward compatible)
  • No (breaking changes)

xyzou685 and others added 5 commits October 18, 2022 15:54
)

* feat(guardrail): add one-sided input and calculation for single comparison

* feat(guardrail): add one-sided calculation for multiple comparisons

* update alternative question

* add test

* update fixed output

* remove redundant code

* fix patched variable

* add todo and update tests

* chore(deps): update actions/setup-python digest to 13ae5bb (#56)

* feat(guardrail): add one-sided input and calculation for single comparison

* reformat

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@xyzou685 xyzou685 requested review from vjohnson1-godaddy and dfu-godaddy and removed request for vjohnson1-godaddy October 21, 2022 21:15
Copy link
Contributor

@vjohnson1-godaddy vjohnson1-godaddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@xyzou685 xyzou685 merged commit 2c8f305 into main Oct 31, 2022
@xyzou685 xyzou685 deleted the one-sided-test branch October 31, 2022 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants