Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

custom tags are not generated for oneof filed #611

Closed
krhubert opened this issue Aug 29, 2019 · 1 comment
Closed

custom tags are not generated for oneof filed #611

krhubert opened this issue Aug 29, 2019 · 1 comment
Labels
Milestone

Comments

@krhubert
Copy link
Contributor

krhubert commented Aug 29, 2019

Hi,

following message:

syntax = "proto3";
  
import "gogo/protobuf/gogoproto/gogo.proto";

message T {
  oneof v {
    string s = 1 [
      (gogoproto.moretags) = 'customtag:"s"'
    ];
  }
}

will generate

$ protoc --gogofaster_out=. t.proto

go struct

type T_S struct {
  S string `protobuf:"bytes,1,opt,name=s,proto3,oneof"`
}

So the tags are not injected into oneof fields.

@jmarais
Copy link
Contributor

jmarais commented Sep 5, 2019

Thanks for logging the bug. Please see the pull request comments.

@jmarais jmarais added the bug label Sep 5, 2019
@jmarais jmarais added this to the v1.3.0 milestone Sep 7, 2019
jmarais pushed a commit that referenced this issue Sep 8, 2019
@krhubert krhubert closed this as completed Sep 9, 2019
timpalpant pushed a commit to timpalpant/protobuf that referenced this issue Oct 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants