feat: stop scan job proposal #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zyyw
force-pushed
the
stop-scan-job-proposal
branch
from
0eb54e4
to
eb6d951
Compare
zyyw
force-pushed
the
stop-scan-job-proposal
branch
from
1989b1d
to
0aa013a
Compare
Signed-off-by: Shengwen Yu <yshengwen@vmware.com>
zyyw
force-pushed
the
stop-scan-job-proposal
branch
from
0aa013a
to
4d8e7e1
Compare
|
This isn't new to this proposal, but starting a new scan job immediately removes/invalidates the results of any previous successful scan job. I think this is relevant here because this new functionality highlights that by adding a new "Scan Job Cancelled" state that gets displayed -- my immediate thought seeing that in today's demo was wondering how we could get back that previous scan result. Could we maybe defer actually removing the previous scan result until the new scan is finished so that if the new scan is cancelled the old report can still show? It would definitely be useful to be able to see more historical data on scans (which results are new, etc), but that's a totally separate feature request (and I'm not asking for that here). |
Signed-off-by: Shengwen Yu <yshengwen@vmware.com>
heww
approved these changes
Nov 1, 2021
reasonerjt
approved these changes
Nov 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Shengwen Yu yshengwen@vmware.com