-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
proposal: async update pull_time and pull_count #183
proposal: async update pull_time and pull_count #183
Conversation
e4ecd85
to
d6cb436
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Signed-off-by: chlins <chenyuzh@vmware.com>
d6cb436
to
487f057
Compare
This is slow specifically because it's updating an existing database record, right? What if instead the code just did an append/insert to some "audit" type table for each event (which should be very fast, given the way the database journaling works) and then have a job that periodically (on a delayed trigger of some kind, maybe?) tallied those up for a combined update that does multiple pulls worth at once? |
@tianon Thanks your advice, but actually we already have the access logs in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Fix: goharbor/harbor#15963
Signed-off-by: chlins chenyuzh@vmware.com