Remove os.Kill in signal handling #16111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: heylongdacoder <heylongdacoder@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #16111 +/- ##
=======================================
Coverage 66.78% 66.78%
=======================================
Files 941 941
Lines 77924 77924
Branches 2293 2293
=======================================
+ Hits 52044 52045 +1
+ Misses 21859 21858 -1
Partials 4021 4021
Flags with carried forward coverage won't be shown. Click here to find out more.
|
stonezdj
approved these changes
Mar 31, 2022
|
This PR is being marked stale due to a period of inactivty. If this PR is still relevant, please comment or remove the stale label. Otherwise, this PR will close in 30 days. |
Vad1mo
approved these changes
Jul 5, 2022
Vad1mo
added
the
release-note/enhancement
sluetze
pushed a commit
to sluetze/harbor
that referenced
this pull request
Oct 29, 2022
os.Kill cannot be trapped. May refer to SA1016
mcsage
pushed a commit
to mcsage/harbor
that referenced
this pull request
Feb 16, 2023
os.Kill cannot be trapped. May refer to SA1016 Signed-off-by: Stephan Hohn <stephan.hohn@tech11.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
os.Kill cannot be trapped. May refer to SA1016
Signed-off-by: heylongdacoder heylongdacoder@gmail.com