Add options to the user.Count method #16285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #16285 +/- ##
==========================================
- Coverage 71.41% 67.03% -4.39%
==========================================
Files 746 980 +234
Lines 69394 82354 +12960
Branches 0 2630 +2630
==========================================
+ Hits 49557 55205 +5648
- Misses 16357 23353 +6996
- Partials 3480 3796 +316
Flags with carried forward coverage won't be shown. Click here to find out more.
|
wy65701436
reviewed
Jan 26, 2022
stonezdj
force-pushed
the
22jan25_user_count_mismatch
branch
3 times, most recently
from
81f7702
to
39ef475
Compare
ywk253100
reviewed
Jan 26, 2022
stonezdj
force-pushed
the
22jan25_user_count_mismatch
branch
from
39ef475
to
8adb47f
Compare
stonezdj
force-pushed
the
22jan25_user_count_mismatch
branch
from
8adb47f
to
224cc1a
Compare
ywk253100
approved these changes
Mar 23, 2022
Fixes goharbor#16269, exclude the admin account by default Add excludeDefaultAdmin method -- exclude default admin by option Update authModeCanBeModified method -- the user count should be 0 without admin Signed-off-by: stonezdj <stonezdj@gmail.com>
stonezdj
force-pushed
the
22jan25_user_count_mismatch
branch
from
224cc1a
to
cbf0296
Compare
sluetze
pushed a commit
to sluetze/harbor
that referenced
this pull request
Oct 29, 2022
Fixes goharbor#16269, exclude the admin account by default Add excludeDefaultAdmin method -- exclude default admin by option Update authModeCanBeModified method -- the user count should be 0 without admin Signed-off-by: stonezdj <stonezdj@gmail.com>
mcsage
pushed a commit
to mcsage/harbor
that referenced
this pull request
Feb 16, 2023
Fixes goharbor#16269, exclude the admin account by default Add excludeDefaultAdmin method -- exclude default admin by option Update authModeCanBeModified method -- the user count should be 0 without admin Signed-off-by: stonezdj <stonezdj@gmail.com> Signed-off-by: Stephan Hohn <stephan.hohn@tech11.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exclude the admin account by default
Fixes #16269
Signed-off-by: stonezdj stonezdj@gmail.com